Skip to content

bump the version of virtualenv we use#120

Merged
Rob-Johnson merged 1 commit into
masterfrom
u/robj/bump-venv
Mar 25, 2026
Merged

bump the version of virtualenv we use#120
Rob-Johnson merged 1 commit into
masterfrom
u/robj/bump-venv

Conversation

@Rob-Johnson

Copy link
Copy Markdown
Contributor

we need a more recent one to guarantee python 3.12 support

@nemacysts nemacysts left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(left a comment, but feel free to merge anyway if you wanna disagree and commit - it's not particularly important :p)

Comment thread src/tox.ini Outdated
[tox]
envlist=py312-linux
requires =
virtualenv>=20.24.6

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we usually do this in a requirements-bootstrap.txt - but for now this is probably fine: i'd maybe just == pin this to be consistent with how we usually do this in requirements-bootstrap.txt tho

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, yeah, I can't use the internal tox-requirements-bootstrap plugin here, and I need the package upgrades in the tox setup. the top level [tox] config section doesn't support -r requirements-bootstrap.txt, so I'll have to dupe from requirements-bootstrap.txt here :(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I just copied the entirety of the requirements-bootstrap.txt file into this section

match the bootstrap deps with requirements-bootstrap.txt - there's no
support for installing from that file directly in this part of the tox
config.
@Rob-Johnson Rob-Johnson merged commit 2327c12 into master Mar 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants