Skip to content

P2-1057 Fix breadcrumb for static posts page - #17161

Merged
abotteram merged 5 commits into
release/16.6from
fix-static-posts-page-breadcrumb
Jun 21, 2021
Merged

P2-1057 Fix breadcrumb for static posts page#17161
abotteram merged 5 commits into
release/16.6from
fix-static-posts-page-breadcrumb

Conversation

@herregroen

@herregroen herregroen commented Jun 17, 2021

Copy link
Copy Markdown
Contributor

Context

  • Prevents stripping the final breadcrumb for the static posts page as this page does not have a page crumb.

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where the last breadcrumb item was stripped in breadcrumb Schema output on subsequent pages of a static posts page.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Set a static posts page.
  • Go to the second page of it.
  • The second breadcrumb item should be present.

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • Breadcrumbs schema generation.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

@herregroen herregroen added this to the 16.6 milestone Jun 17, 2021
@herregroen herregroen added the changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog label Jun 17, 2021
Comment thread src/generators/schema/breadcrumb.php
@increddibelly

Copy link
Copy Markdown
Contributor

image
after this PR, Breadcrumb schema is as seen in screenshot.

@abotteram abotteram added changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog and removed changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog labels Jun 21, 2021
@abotteram
abotteram merged commit 601fc41 into release/16.6 Jun 21, 2021
@abotteram
abotteram deleted the fix-static-posts-page-breadcrumb branch June 21, 2021 07:13
@ghost ghost changed the title Fix breadcrumb for static posts page P2-1057 Fix breadcrumb for static posts page Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants