Merged
Conversation
…e array key in data provider ... which essentially meant that the first data set using that name was not being run in the tests.
The second instance of the array key encountered would overwrite the value of the first, so removing the first of the two array keys will maintain the existing behaviour.
jrfnl
added
yoast cs/qa
changelog: non-user-facing
Pull Request Test Coverage Report for Build 7254294283
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
CS/QA | Content_Type_Visibility_Watcher_Actions_Test: rename duplicate array key in data provider
... which essentially meant that the first data sets using that name were not being run in the tests.
CS/QA | Admin_Columns_Cache_Integration_Test: fix test expectation
The second instance of the array key encountered would overwrite the value of the first, so removing the first of the two array keys will maintain the existing behaviour.
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps: