Skip to content

Shorten test files and classes names - #23522

Merged
enricobattocchi merged 1 commit into
trunkfrom
23518-shorten-woo-product-type-listener-test-names
Jul 30, 2026
Merged

Shorten test files and classes names#23522
enricobattocchi merged 1 commit into
trunkfrom
23518-shorten-woo-product-type-listener-test-names

Conversation

@pls78

@pls78 pls78 commented Jul 29, 2026

Copy link
Copy Markdown
Member

Long paths can cause issues in Windows dev envs

Context

  • N/A

Summary

This PR can be summarized in the following changelog entry:

  • Shortens some file names as they can cause issues in Windows-based development environments.

Relevant technical choices:

  • N/A

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • No tests needed, this is just unit tests.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • Only test files.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.
  • This PR also affects Yoast SEO for Google Docs. I have added a changelog entry starting with [yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached the Google Docs Add-on label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.
  • I have run grunt build:images and committed the results, if my PR introduces or edits images or SVGs.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #23518

Long paths can cause issues in Windows dev envs
@pls78 pls78 added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Jul 29, 2026
@pls78
pls78 marked this pull request as ready for review July 29, 2026 13:05
@coveralls-official

Copy link
Copy Markdown

Coverage Report for CI Build 588827

Coverage decreased (-0.4%) to 55.054%

Details

  • Coverage decreased (-0.4%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 70387
Covered Lines: 38671
Line Coverage: 54.94%
Relevant Branches: 17314
Covered Branches: 9612
Branch Coverage: 55.52%
Branches in Coverage %: Yes
Coverage Strength: 42757.25 hits per line

💛 - Coveralls

@enricobattocchi enricobattocchi added this to the 28.3 milestone Jul 30, 2026
@enricobattocchi
enricobattocchi merged commit f16b16d into trunk Jul 30, 2026
31 checks passed
@enricobattocchi
enricobattocchi deleted the 23518-shorten-woo-product-type-listener-test-names branch July 30, 2026 07:59
@pls78 pls78 mentioned this pull request Jul 30, 2026
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shorten tests/Unit/Schema_Aggregator/User_Interface/Cache/WooCommerce_Product_Type_Change_Listener_Integration/* filenames and class names

2 participants