PHPCS: bug fix - prevent error for property which is not always available (incl changelog 3.4.1)#428
Open
PHPCS: bug fix - prevent error for property which is not always available (incl changelog 3.4.1)#428
Conversation
…able Turns out the `checkIfConditions` property for the `SlevomatCodingStandard.ControlStructures.RequireNullCoalesceEqualOperator` sniff is only available as of Slevomat 8.17.0. As Slevomat raised their minimum PHP version to PHP 7.4 in v 8.16.0 and this package still supports a minimum of PHP 7.2, the version constraint for the Slevomat dependency cannot be changed for the time being. If we set the property directly on the sniff (like originally done), PHPCS will error out with the following error message when run with Slevomat < 8.17.0: ``` ERROR: Property "checkIfConditions" does not exist on sniff SlevomatCodingStandard.ControlStructures.RequireNullCoalesceEqualOperator. ``` So, even though the property is useful for those Yoast packages which can run with a higher Slevomat version (i.e. all packages which have a PHP 7.4 minimum and no conflicting dependencies), we unfortunately cannot (yet) set it by default. Ref: * slevomat/coding-standard@2031373 * https://github.com/slevomat/coding-standard/releases/tag/8.17.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the
checkIfConditionsproperty for theSlevomatCodingStandard.ControlStructures.RequireNullCoalesceEqualOperatorsniff is only available as of Slevomat 8.17.0.As Slevomat raised their minimum PHP version to PHP 7.4 in v 8.16.0 and this package still supports a minimum of PHP 7.2, the version constraint for the Slevomat dependency cannot be changed for the time being.
If we set the property directly on the sniff (like originally done), PHPCS will error out with the following error message when run with Slevomat < 8.17.0:
So, even though the property is useful for those Yoast packages which can run with a higher Slevomat version (i.e. all packages which have a PHP 7.4 minimum and no conflicting dependencies), we unfortunately cannot (yet) set it by default.
Ref: