Skip to content

Fix codecov CI and update template#6

Merged
adamgayoso merged 3 commits intoYosefLab:mainfrom
grst:template-update-2023-04-13
Apr 14, 2023
Merged

Fix codecov CI and update template#6
adamgayoso merged 3 commits intoYosefLab:mainfrom
grst:template-update-2023-04-13

Conversation

@grst
Copy link
Copy Markdown
Contributor

@grst grst commented Apr 14, 2023

This PR fixes some problems with the CI setup of the scverse-cookiecutter template repo. Last night, the codecov package was pulled from PyPI. This can easily be replaced, however we've realized our automatic template sync system does not allow us to modify github actions (a security precaution from github), so we need to roll out this update manually.

We're also taking this opportunity to make several other intended changes for to the CI workflow.

We're still looking into how we can avoid this in the future, which will likely require us changing how our template sync system works. This is being tracked in the scverse/cookiecutter-scverse#138.

Changes

These changes constitute the 0.2.1 release of the template and make the following changes:

Additional remarks

  • If there are merge conflicts, they either show up inline (>>>>>>>) or a .rej file will have been created for the respective files. You need to address these conflicts manually. Make sure to enable pre-commit.ci (see below) to detect such files.
  • The scverse template works best when the pre-commit.ci, readthedocs and codecov services are enabled. Make sure to activate those apps if you haven't already.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0259448) 52.58% compared to head (8ed8d19) 52.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage   52.58%   52.58%           
=======================================
  Files           6        6           
  Lines         831      831           
=======================================
  Hits          437      437           
  Misses        394      394           
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamgayoso adamgayoso merged commit bacfac8 into YosefLab:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants