Both repos have a passing test suite that runs on pull requests but not on the workflow that builds and publishes to the site — so a regression merged to main still deploys.
YurMil/Pipe-notch-generator — 31 tests, deploy.yml runs build only
YurMil/pdfs-master — 22 tests, deploy.yml runs build only
For comparison, Blind Flange, Tube Sheet and Dished End all run their tests before building in the deploy path.
Acceptance criteria:
Found while writing the QA strategy page (#105).
This repo is using Opire - what does it mean? 👇
💵 Everyone can add rewards for this issue commenting /reward 100 (replace 100 with the amount).
🕵️♂️ If someone starts working on this issue to earn the rewards, they can comment /try to let everyone know!
🙌 And when they open the PR, they can comment /claim #152 either in the PR description or in a PR's comment.
🪙 Also, everyone can tip any user commenting /tip 20 @YurMil (replace 20 with the amount, and @YurMil with the user to tip).
📖 If you want to learn more, check out our documentation.
Both repos have a passing test suite that runs on pull requests but not on the workflow that builds and publishes to the site — so a regression merged to
mainstill deploys.YurMil/Pipe-notch-generator— 31 tests,deploy.ymlruns build onlyYurMil/pdfs-master— 22 tests,deploy.ymlruns build onlyFor comparison, Blind Flange, Tube Sheet and Dished End all run their tests before building in the deploy path.
Acceptance criteria:
npm test/pnpm testruns before the build step in both deploy workflowsFound while writing the QA strategy page (#105).
This repo is using Opire - what does it mean? 👇
💵 Everyone can add rewards for this issue commenting
/reward 100(replace100with the amount).🕵️♂️ If someone starts working on this issue to earn the rewards, they can comment
/tryto let everyone know!🙌 And when they open the PR, they can comment
/claim #152either in the PR description or in a PR's comment.🪙 Also, everyone can tip any user commenting
/tip 20 @YurMil(replace20with the amount, and@YurMilwith the user to tip).📖 If you want to learn more, check out our documentation.