Skip to content

[REFACTOR] RESULT-01 회의 참석자 조회 API 코드 제거 - #455

Merged
MNPPI223 merged 1 commit into
developfrom
feat/mo-rfrf
Aug 13, 2026
Merged

[REFACTOR] RESULT-01 회의 참석자 조회 API 코드 제거#455
MNPPI223 merged 1 commit into
developfrom
feat/mo-rfrf

Conversation

@mosungjin

@mosungjin mosungjin commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Result-01에 대한 회의 참석자 조회는 정책 상 필요 없다고 프론트와 얘기 후 삭제

Summary by CodeRabbit

  • 변경 사항

    • 회의 참석자 명단 조회 기능이 제거되었습니다.
    • 참석자 목록을 반환하던 관련 응답 형식과 조회 경로가 더 이상 제공되지 않습니다.
    • 회의 참석자 명단 교체 기능은 계속 사용할 수 있습니다.
    • 회의 단건 조회 및 기타 회의 조회 기능은 기존과 동일하게 유지됩니다.
  • 테스트

    • 참석자 명단 교체와 회의 조회 동작에 맞게 검증 항목을 정비했습니다.

FE·타 도메인 호출처가 없어 제거 결정. GetMeetingAttendeesUseCase·Query·
Result·전용 응답 DTO(MeetingAttendeeListResponse·MeetingAttendeeResponse)와
MeetingAttendeeController의 GET 매핑을 지웠다. 같은 컨트롤러·서비스가
맡던 MEET-09(PUT 참석자 명단 교체)와 MeetingQueryPort(E·C 내부 연동,
같은 findAndValidateMembers·hostFirst 헬퍼 재사용)는 그대로 둔다.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@mosungjin
mosungjin requested a review from MNPPI223 August 13, 2026 02:27
@mosungjin mosungjin self-assigned this Aug 13, 2026
@mosungjin mosungjin added the enhancement New feature or request label Aug 13, 2026
@mosungjin mosungjin added this to Z Aug 13, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Z Aug 13, 2026
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 744b7b42-9022-4ef4-89bc-904cd635a77f

📥 Commits

Reviewing files that changed from the base of the PR and between b61199f and cc1b0d8.

📒 Files selected for processing (13)
  • src/main/java/com/module06/backend/meeting/application/query/GetMeetingAttendeesQuery.java
  • src/main/java/com/module06/backend/meeting/application/result/MeetingAttendeesResult.java
  • src/main/java/com/module06/backend/meeting/application/service/MeetingQueryService.java
  • src/main/java/com/module06/backend/meeting/application/usecase/GetMeetingAttendeesUseCase.java
  • src/main/java/com/module06/backend/meeting/domain/repository/MeetingQueryRepository.java
  • src/main/java/com/module06/backend/meeting/infrastructure/persistence/adapter/MeetingQueryPersistenceAdapter.java
  • src/main/java/com/module06/backend/meeting/presentation/api/MeetingAttendeeController.java
  • src/main/java/com/module06/backend/meeting/presentation/api/response/MeetingAttendeeListResponse.java
  • src/main/java/com/module06/backend/meeting/presentation/api/response/MeetingAttendeeResponse.java
  • src/test/java/com/module06/backend/meeting/application/service/MeetingQueryServiceTest.java
  • src/test/java/com/module06/backend/meeting/application/service/UpcomingMeetingQueryServiceTest.java
  • src/test/java/com/module06/backend/meeting/infrastructure/persistence/adapter/MeetingQueryPersistenceAdapterTest.java
  • src/test/java/com/module06/backend/meeting/presentation/api/MeetingAttendeeControllerTest.java
💤 Files with no reviewable changes (5)
  • src/main/java/com/module06/backend/meeting/presentation/api/response/MeetingAttendeeResponse.java
  • src/main/java/com/module06/backend/meeting/application/result/MeetingAttendeesResult.java
  • src/main/java/com/module06/backend/meeting/presentation/api/response/MeetingAttendeeListResponse.java
  • src/main/java/com/module06/backend/meeting/application/usecase/GetMeetingAttendeesUseCase.java
  • src/main/java/com/module06/backend/meeting/application/query/GetMeetingAttendeesQuery.java

📝 Walkthrough

Walkthrough

회의 참석자 조회 유스케이스, 서비스 메서드, 응답 DTO, 컨트롤러 GET API를 제거했습니다. 컨트롤러 테스트는 참석자 명단 교체 API를 검증하도록 변경했습니다. 회의 조회 관련 계약 설명도 갱신했습니다.

Changes

회의 참석자 조회 제거

Layer / File(s) Summary
조회 계약과 서비스 구현 제거
src/main/java/com/module06/backend/meeting/application/..., src/test/java/com/module06/backend/meeting/application/service/MeetingQueryServiceTest.java
GetMeetingAttendeesUseCase, 조회 쿼리와 결과 타입, MeetingQueryService의 참석자 조회 구현을 제거했습니다. 서비스 테스트는 MeetingQueryPort 조회와 참석자 변환 검증을 유지합니다.
참석자 GET 흐름 제거
src/main/java/com/module06/backend/meeting/presentation/api/MeetingAttendeeController.java, src/test/java/com/module06/backend/meeting/presentation/api/MeetingAttendeeControllerTest.java
컨트롤러에서 참석자 조회 API와 조회 유스케이스 의존성을 제거했습니다. 테스트는 참석자 명단 교체 API를 검증합니다.
회의 조회 계약 설명 정리
src/main/java/com/module06/backend/meeting/domain/repository/MeetingQueryRepository.java, src/main/java/com/module06/backend/meeting/infrastructure/persistence/adapter/MeetingQueryPersistenceAdapter.java, src/test/java/com/module06/backend/meeting/...
RESULT-01 참조를 제거하고 E 인수인계 및 단건 조회 중심의 설명으로 변경했습니다. 관련 테스트 설명의 기능 식별자도 갱신했습니다.

Estimated code review effort: 2 (Simple) | ~15 minutes

Mergeability Score: ⚪ Minimal · up to cc1b0

This change removes the Result-01 meeting-attendee lookup API and its related code as an agreed policy change. No actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

Suggested reviewers: mnppi223, hyunj11

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 RESULT-01 회의 참석자 조회 API 관련 코드 제거라는 변경의 핵심을 정확하고 간결하게 설명합니다.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/mo-rfrf

Comment @coderabbitai help to get the list of available commands.

@MNPPI223 MNPPI223 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.
고생하셨어요.

@MNPPI223
MNPPI223 merged commit 010a893 into develop Aug 13, 2026
15 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Z Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants