fix: Correct MX value docs and validate admin record names#235
Merged
Conversation
aded3cd to
1ec26fe
Compare
86658e5 to
c13ed87
Compare
c13ed87 to
ba290f3
Compare
ba290f3 to
92b75c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
probeRRvalidation viadns.NewRR) requires a preference before the exchange host, e.g.10 mail.example.com.. Following the old docs made every MX creation fail withinvalid_record_value. Docs are now corrected, and the previously untested MX create → serve path has test coverage (TestAdminCreateMXRecord,TestAnswerManagedMXRecord) proving the existing validation/serving logic was already correct.adminCreateRecord/adminUpdateRecordpreviously only rejected an emptyname, so a name containing whitespace or control characters (e.g. a newline) would be stored and later spliced unescaped into the RR string built for DNS responses. AddedvalidRecordName(label length/charset checks, blocks whitespace/newlines, allows_-prefixed labels and wildcard*) and wired it into both handlers.Test plan
go build ./...go vet ./...go test ./...