fix: consolidate redundant theorem tabs (closes #13)#15
Merged
Conversation
- Move TheoremDoc for Set.union_subset from LinearIndependenceSpanWorld/Level07 to VectorSpaceWorld/Level05, alongside its NewTheorem. Previously the theorem fell into a namespace-default "Set" tab (with only itself) when first introduced, before its TheoremDoc was seen. Now it lands in "Sets" immediately. - In InnerProductWorld/Level03, unify tab names to the Unicode form used elsewhere in the world: "Real Numbers" → "ℝ" (3x), "Complex Numbers" → "ℂ" (2x). Eliminates side-by-side duplicate tabs for the same concept. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
after making commits , you need to go to the github actions that succeeded, go to build and deploy , then to 'What Next?' and click the trigger url which would update the game on the lean 4 game server for users to actually see. |
|
I verified the two remaining points in the test plan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #13 by eliminating two forms of redundant theorem tabs that Jad noticed while playing:
Set→Setstab.Set.union_subsetwas introduced viaNewTheoreminVectorSpaceWorld/Level05.leanbut itsTheoremDoc … in "Sets"declaration lived inLinearIndependenceSpanWorld/Level07.lean. Between those worlds the game fell back to a namespace-defaultSettab containing only that one theorem. Fix: move theTheoremDoctoVectorSpaceWorld/Level05.leanalongside theNewTheorem, so the theorem lands inSetsfrom first introduction.Unify
ℝ/ℂtabs.InnerProductWorld/Level03.leanmixed two naming conventions side-by-side:in "ℝ"/in "ℂ"vsin "Real Numbers"/in "Complex Numbers". Picked the Unicode form (matchingTheoremTab "ℂ"inLevel02.leanand other uses in the world). Changed 3xReal Numbers→ℝand 2xComplex Numbers→ℂ.Test plan
lake build— 3229 jobs, exit 0, no new warnings introducedSet.union_subsetnow appears in theSetstab from Vector Space World Level 5 onwardℝandℂtabs in Inner Product World Level 3 each contain all the relevant theorems with no duplicateReal Numbers/Complex NumberstabsOut of scope
{h}hint interpolation sweep (follow-up PR, extending @JadAbouHawili's PR make hypothesis name compatible with user choice #11 pattern to other hidden hints referencing hypothesis names).🤖 Generated with Claude Code