Skip to content

🧪 Add tests for get_rknn_model_type - #208

Merged
ManupaKDU merged 1 commit into
devfrom
jules-test-rknn-compat-9431757256177787303
Aug 15, 2026
Merged

🧪 Add tests for get_rknn_model_type#208
ManupaKDU merged 1 commit into
devfrom
jules-test-rknn-compat-9431757256177787303

Conversation

@ManupaKDU

Copy link
Copy Markdown

🎯 What: Adds missing unit tests for get_rknn_model_type in frigate/util/rknn_converter.py.
📊 Coverage: Covered "jina-clip-v1-vision", "arcface-r100", "yolo" variants, and unsupported model path parsing. Test coverage for frigate/util/rknn_converter.py is improved, covering lines 46-57.
Result: Enhanced test coverage and reliability for RKNN model compatibility utilities.


PR created automatically by Jules for task 9431757256177787303 started by @manupawickramasinghe

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions

Copy link
Copy Markdown

PR template validation notice

The PR description could not be validated against the pull request template.

Items to review:

  • Missing section: ## Proposed change
  • Missing section: ## Type of change
  • Missing section: ## AI disclosure
  • Missing section: ## Checklist
  • The Proposed change section is empty. Please describe what this PR does.

Please consider updating your PR description to include all required sections from the template.

@ManupaKDU
ManupaKDU merged commit ec44b05 into dev Aug 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant