🧪 Add tests for get_rknn_model_type - #208
Conversation
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
PR template validation noticeThe PR description could not be validated against the pull request template. Items to review:
Please consider updating your PR description to include all required sections from the template. |
🎯 What: Adds missing unit tests for
get_rknn_model_typeinfrigate/util/rknn_converter.py.📊 Coverage: Covered "jina-clip-v1-vision", "arcface-r100", "yolo" variants, and unsupported model path parsing. Test coverage for
frigate/util/rknn_converter.pyis improved, covering lines 46-57.✨ Result: Enhanced test coverage and reliability for RKNN model compatibility utilities.
PR created automatically by Jules for task 9431757256177787303 started by @manupawickramasinghe