Skip to content

🔒 Sentinel: [CRITICAL] Fix JPQL injection in findByFilter methods - #184

Merged
ManupaKDU merged 1 commit into
developmentfrom
fix/jpql-injection-findByFilter-3928353406992480341-5915833914436768588
Jul 22, 2026
Merged

🔒 Sentinel: [CRITICAL] Fix JPQL injection in findByFilter methods#184
ManupaKDU merged 1 commit into
developmentfrom
fix/jpql-injection-findByFilter-3928353406992480341-5915833914436768588

Conversation

@ManupaKDU

Copy link
Copy Markdown

🎯 What: Fixed a critical JPQL injection vulnerability in multiple Bill Controllers (findByFilter method) where the property parameter was directly concatenated into the JPQL query string.

⚠️ Risk: An attacker could exploit this by providing a crafted property string, potentially allowing them to bypass logic, enumerate data, or execute arbitrary JPQL commands, leading to data exposure or corruption.

🛡️ Solution: Implemented a strict allowlist (whitelist) validation. The property parameter is now validated against a list of known safe and expected field names (e.g., "insId", "deptId", "patient.person.name") before the query is constructed. If the property is not in the allowlist, the method safely returns false, completely preventing the injection.

Affected Controllers:

  • OpdOrderController
  • OpdPreBillController
  • BillController
  • OpdBatchBillCancellationController
  • OpdTabPreBillController
  • CollectingCentreBillController
  • OpticianRepairBillController
  • OpdBillController

PR created automatically by Jules for task 5915833914436768588 started by @manupawickramasinghe

Implemented a strict allowlist validation for the dynamic 'property' parameter in findByFilter methods across all Bill Controllers to prevent SQL/JPQL injection.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ManupaKDU
ManupaKDU merged commit 054a983 into development Jul 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant