🔒 Fix path traversal vulnerability in HttpServer - #15
Conversation
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Fixed a path traversal vulnerability in the
ReturnFilemethod inUtilities/HttpServer.csby ensuring that the resolved absolute path starts with the application's base directory.../../Windows/System32/config/SAM) in HTTP requests and read any file on the filesystem that the application process has permissions to read. This would result in sensitive information disclosure.🛡️ Solution: The method now constructs the expected root directory using
AppDomain.CurrentDomain.BaseDirectoryand normalizes the requested path usingPath.GetFullPath(Path.Combine(...)). It checks if the requested path falls under the expected root directory and rejects requests that escape it with a 403 Forbidden HTTP status, eliminating the path traversal vulnerability.PR created automatically by Jules for task 16989806303177403089 started by @manupawickramasinghe