Skip to content

🔒 Fix path traversal vulnerability in HttpServer - #15

Merged
manupawickramasinghe merged 1 commit into
masterfrom
security-fix-path-traversal-16989806303177403089
Jul 23, 2026
Merged

🔒 Fix path traversal vulnerability in HttpServer#15
manupawickramasinghe merged 1 commit into
masterfrom
security-fix-path-traversal-16989806303177403089

Conversation

@ManupaKDU

Copy link
Copy Markdown

🎯 What: Fixed a path traversal vulnerability in the ReturnFile method in Utilities/HttpServer.cs by ensuring that the resolved absolute path starts with the application's base directory.

⚠️ Risk: Without this fix, malicious users could send arbitrary paths (e.g. ../../Windows/System32/config/SAM) in HTTP requests and read any file on the filesystem that the application process has permissions to read. This would result in sensitive information disclosure.

🛡️ Solution: The method now constructs the expected root directory using AppDomain.CurrentDomain.BaseDirectory and normalizes the requested path using Path.GetFullPath(Path.Combine(...)). It checks if the requested path falls under the expected root directory and rejects requests that escape it with a 403 Forbidden HTTP status, eliminating the path traversal vulnerability.


PR created automatically by Jules for task 16989806303177403089 started by @manupawickramasinghe

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@manupawickramasinghe
manupawickramasinghe merged commit 97b621c into master Jul 23, 2026
@manupawickramasinghe
manupawickramasinghe deleted the security-fix-path-traversal-16989806303177403089 branch July 23, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants