🧹 Refactor VulkanHostSurface methods to use block bodies - #11
Conversation
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Syncs the fork with 21 upstream commits (PR #25), covering the SDL host window backend, AGC shader translation fixes, AudioOut2 host beds, kernel memory/getdents fixes and the Avalonia 12 / SDL3 dependency bump. Conflict resolution (upstream wins on semantics, fork perf tweaks reapplied): - VulkanHostSurface.cs: deleted upstream by "Sdl backend (sharpemu#670)", which replaces it with SdlHostWindow.cs. The fork only had expression-body -> block-body edits here (PRs #9/#11), so the deletion is taken as-is. - VulkanVideoPresenter.cs: took upstream's new baseVertex argument and kept the fork's allocation fix that drops the defensive targets.ToArray() copy, matching the five sibling call sites that merged cleanly. Restores upstream's workflow.yml, undoing a bot downgrade of actions/checkout from v6 to v4. Removes files committed by accident during the bot PR runs, which had been failing CI since 2026-07-26: .reuse/dep5 (REUSE lint hard-errors when both it and REUSE.toml exist, and the reuse job gates the build job, so the Windows build and tests had not run since), a duplicate reuse.yml workflow, patch*.diff / fix_reuse*.diff, root-level benchmark scaffolding, and committed .orig/.rej patch leftovers. Replaces tests/SharpEmu.Core.Tests/Loader/SelfLoaderTests.cs, which was a benchmark script with no test attributes, no csproj and no solution entry, with real xunit coverage of SelfLoader's import-stub eligibility rules and relocation value arithmetic. These paths were previously asserted only in RunRelocationSelfChecks, which is [Conditional("DEBUG")] and so never ran in CI's Release build. Widens six SelfLoader members from private to internal for test access; no behaviour change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🎯 What: Converted
TryAttachSurface,DetachSurface, andRequestClosemethods inVulkanVideoHost(withinVulkanHostSurface.cs) from expression-bodied to block-bodied format using standard Allman style formatting.💡 Why: Converting methods with side effects to block bodies improves the readability and maintainability of the codebase, ensuring consistency across the file without changing behavior.
✅ Verification: Ran
dotnet buildanddotnet testto confirm compilation success and passing tests. Reviewed changes to ensure event accessors and properties correctly remained expression-bodied.✨ Result: Improved readability and consistency within
VulkanVideoHost.PR created automatically by Jules for task 14639079587607880975 started by @manupawickramasinghe