⚡ Bolt: Optimize guest string comparison allocations and lock contention - #13
Conversation
- Updated `TryCompareStrings` and `TryCompareStringsCaseInsensitive` in `KernelMemoryCompatExports.cs`. - Replaced per-byte `TryReadCompat` loops with 4KB chunked stack allocations. - Ensures zero allocations while minimizing lock contention on `VirtualMemory` accesses during HLE syscall string operations. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Updated
TryCompareStringsandTryCompareStringsCaseInsensitiveto use chunked memory reading with 4KBstackallocspans instead of 1-byte iterative reads. This prevents acquiring read locks per byte during string comparisons in guest space.🎯 Subsystem & Bottleneck
src/SharpEmu.Libs/Kernel/KernelMemoryCompatExports.csTryReadCompatbeing called per byte on long strings.📜 Git & Contributor Context
📊 Measured Performance Impact
VirtualMemorylock acquisitions to O(N/4096).🔬 Verification Checklist
dotnet test(All tests passed)dotnet formatPR created automatically by Jules for task 13762838680573309854 started by @manupawickramasinghe