⚡ Bolt: Optimize Metal PSO caching by using zero-allocation struct key - #15
Conversation
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
💡 What
Converted the
PipelineKeyused in the Metal backend's Pipeline State Object (PSO) cache from asealed recordto areadonly structimplementingIEquatable<PipelineKey>.🎯 Subsystem & Bottleneck
src/SharpEmu.Libs/Gpu/Metal/MetalVideoPresenter.Draws.csrecordtypes are reference types (classes). When used as keys in aDictionary, creating anew PipelineKey(...)to perform a lookup allocates memory on the managed heap. Since PSO cache lookups occur frequently per-frame and per-draw, this introduced significant GC pressure. By migrating to a value-typestructwith a manualIEquatable<T>implementation, these allocations are eliminated.📜 Git & Contributor Context
PipelineKey).📊 Measured Performance Impact
recordhashing/equality generation with directReferenceEqualsandHashCode.Combinestruct comparison, slightly improving CPU overhead while achieving strict zero-allocation limits.🔬 Verification Checklist
dotnet test SharpEmu.slnx(All tests passed)dotnet format SharpEmu.slnx --verify-no-changesPR created automatically by Jules for task 8632728077925929207 started by @manupawickramasinghe