⚡ Bolt: Optimize Kernel string memory operations - #2
Conversation
Replaced byte-by-byte loops in `Strchr`, `Strrchr`, and `Memchr` with 4KB chunked reads leveraging `Span<byte>.IndexOf`. This eliminates massive overhead from `TryReadCompat` lock acquisitions and tree lookups, reducing O(N) memory lookups to O(N/4096). Chunk sizes are strictly bounded to prevent page boundary cross-faults. Memory overhead is 0 bytes via `stackalloc`. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Replaced byte-by-byte memory access in guest string searching operations (
Strchr,Strrchr, andMemchr) with block-aligned chunked reads usingstackalloc byte[4096]andSpan<T>.IndexOf. This ensures the memory searches are now SIMD accelerated internally by the framework while aggressively minimizing memory access lock contention.🎯 Subsystem & Bottleneck
src/SharpEmu.Libs/Kernel/KernelMemoryCompatExports.csTryReadCompat(which triggers aVirtualMemorylookup and read-lock acquisition) for every single byte accessed.📜 Git & Contributor Context
📊 Measured Performance Impact
stackallocon the stack.Span<byte>.IndexOf.🔬 Verification Checklist
dotnet test(All tests passed)dotnet formatPR created automatically by Jules for task 11602529492225016478 started by @manupawickramasinghe