⚡ Bolt: Replace LINQ tuple allocation in TraceAstroTitlePixelGlobalProbe - #67
Conversation
Eliminate closure and tuple heap allocations per iteration by replacing LINQ Select((value, index) => (value, index)) with an indexed for loop. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
📦 Build artifacts —
|
| Platform | Download |
|---|---|
| Windows (win-x64) | sharpemu-win-x64-371433e |
| Linux (linux-x64) | sharpemu-linux-x64-371433e |
| macOS (osx-x64) | sharpemu-osx-x64-371433e |
From build run #138. Downloads require a GitHub login and expire after 90 days.
⚡ Bolt: Replace LINQ tuple allocation in TraceAstroTitlePixelGlobalProbe
💡 What
Replaced LINQ
.Select((value, index) => (value, index))inTraceAstroTitlePixelGlobalProbeinsrc/SharpEmu.Libs/Agc/AgcExports.cswith an indexedforloop accessingevaluation.GlobalMemoryBindings[index]directly.🎯 Subsystem & Bottleneck
SharpEmu.Libs/Agc- Tracing and shader evaluation global memory probe path. The LINQSelectcall allocated a delegate closure and value-tuple pairs for every element inGlobalMemoryBindingson each iteration of the probe function.📜 Git & Contributor Context
Refactored the loop in
AgcExports.csto eliminate heap allocation overhead and added unit tests intests/SharpEmu.Libs.Tests/Agc/AgcTraceTests.cs.📊 Measured Performance Impact
Eliminated 100% of delegate, enumerator, and tuple allocations per invocation of
TraceAstroTitlePixelGlobalProbe.🔬 Verification Checklist
dotnet test SharpEmu.slnx.dotnet format SharpEmu.slnx --verify-no-changes.PR created automatically by Jules for task 9090977947605955005 started by @manupawickramasinghe