[BUG] Vim `$` dollar/end of (display) line does not jump to end of (display) line when line wraps into multiple display lines

[corpserot]

ZenNotes v2.27.0

this one bugs me a lot :( might not be related to #.574

it seems like it just to the middle of the non-display line characterwise in the big paragraph case; and completely ignores the actual line end in the 2 display line case.

dollar.jump.bug.mp4

Looks like this affects vim A append end of line too.

[adibhanna]

Fixed on the current development branch in a16300f, and thanks again for the video: it showed clearly that this was not the intended display-row behavior but a mislanding.

What was happening. A bare $ finds the end of the current display row by asking the editor to hit-test an x coordinate at the viewport's right edge. On your display geometry (the same fractional scaling that triggered #574) that resolution walks sub-pixel glyph rectangles and lands short of the wrap point, or on a neighboring row; from the last row it could even go backward. A shared the landing, as you noticed. On pixel-accurate displays the hit-test happens to work, which is why it never showed up in local testing here.

The fix. The row boundary is now computed from vertical glyph coordinates instead: adjacent rows sit a full row height apart, so a binary search over row midpoints with half-a-row of tolerance is immune to sub-pixel error, and no x coordinate is hit-tested at all. On the last row this returns the actual end of the line by construction, which fixes your second case. $, A, g0, and I all use the new path.

Verified by measuring the true wrap points of two differently-sized wrapped lines in the running app and checking every row: $ lands on each row's last character, A appends right at the boundary and the last row reaches the real line end. Then the whole matrix was re-run with the editor's coordinate hit-testing deliberately skewed to imitate your environment, and it stays correct, since the new path never consults it.

Ships in the next release together with the #574 fix. If a wrapped line still misbehaves for you after that, please reopen with the zoom level and display scale.

[corpserot]

Likely related? <Home> and <End> sometimes does not jump to the (display) line start and end on certain paragraphs. behaves very similarly to the video. I've tested this on a build after the fix (more precisely, on commit 3933732 on the feature/zennotes-cloud branch).

zoom level is 0 (i did not zoom in or out). i don't think there's a display scale setting in zennotes. my laptop display is 1366x768, which is admittedly legacy by today's standards.

i don't have the permission to reopen this issue.