fix: set quick capture window title#174
Closed
dannrs wants to merge 1 commit into
Closed
Conversation
Contributor
|
Merged into the active release branch (`release/v2.4.0`) as b26395b rather than via this PR — your branch also carried two unrelated commits from `main` (the GitHub Sponsors / `FUNDING.yml` changes), so I cherry-picked just your fix commit onto the release branch to keep it clean. Your authorship is preserved on the commit. Nothing was rejected — this ships in v2.4.0. Thanks @dannrs! Clean, correct fix: the constructor `title` plus `document.title` in `QuickCaptureApp` is exactly the right combo so the title sticks after the renderer loads, giving Wayland compositors (niri & co.) a stable `ZenNotes Quick Capture` toplevel to match against. Closes #155. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This small PR fixes the title of the quick capture window, making it distinguishable from the main
ZenNoteswindow on Wayland compositors.The quick capture window now has a different title:
ZenNotes Quick CaptureThis gives compositor rules something stable to match against.
Fixes #155
Testing:
niri.niri msg pick-windowor an equivalent window inspection command.ZenNotes Quick Capture.