Skip to content

Improve settings search recommendations#35

Merged
adibhanna merged 4 commits into
mainfrom
feature/search-setting-names
May 6, 2026
Merged

Improve settings search recommendations#35
adibhanna merged 4 commits into
mainfrom
feature/search-setting-names

Conversation

@adibhanna

@adibhanna adibhanna commented May 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add setting-level search metadata for the Settings modal.
  • Render matched setting names in the settings search sidebar, with the parent section shown as context.
  • Jump to the selected setting when a recommendation is clicked and highlight the target for two seconds.
  • Add a regression test proving wrap returns Word wrap instead of only the Editor section.

Why

Fixes #31 and fixes #32. The previous settings search only filtered top-level sections, so matching a specific setting surfaced the section/type name instead of the actual setting. Clicking a result also did not move the user to the actual control.

Validation

  • npm run test:run --workspace @zennotes/app-core
  • npm run typecheck --workspace @zennotes/app-core
  • npm run typecheck --workspace @zennotes/desktop
  • npm run typecheck --workspace @zennotes/web
  • npm run build:nocheck --workspace @zennotes/web

@adibhanna
adibhanna marked this pull request as ready for review May 6, 2026 15:27
@adibhanna adibhanna changed the title [codex] Show setting names in settings search [codex] Improve settings search recommendations May 6, 2026
@adibhanna
adibhanna marked this pull request as draft May 6, 2026 15:35
@adibhanna adibhanna changed the title [codex] Improve settings search recommendations Improve settings search recommendations May 6, 2026
@adibhanna
adibhanna marked this pull request as ready for review May 6, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant