Skip to content

Fix Faiss edge cases#6

Closed
Zethson wants to merge 7 commits intomainfrom
fix/faiss_edge_cases
Closed

Fix Faiss edge cases#6
Zethson wants to merge 7 commits intomainfrom
fix/faiss_edge_cases

Conversation

@Zethson
Copy link
Owner

@Zethson Zethson commented Jan 17, 2025

  • Added a lot more tests for edge cases and parameter validation
  • Adds a fallback strategy for extremely sparse data where data is simply (= mean/median) imputed.

Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
@Zethson Zethson marked this pull request as ready for review January 18, 2025 12:17
@Zethson Zethson requested a review from nicolassidoux January 18, 2025 12:36
Signed-off-by: Lukas Heumos <lukas.heumos@posteo.net>
@codecov
Copy link

codecov bot commented Jan 18, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@nicolassidoux nicolassidoux linked an issue Feb 5, 2025 that may be closed by this pull request
@Zethson
Copy link
Owner Author

Zethson commented Feb 19, 2025

Closing in favor of #8

@Zethson Zethson closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Imputation sometimes returns an incompletely imputed dataset

1 participant