Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Lint Results
Found 7 issues on changed lines in 6 files:
- port/stmicro/stm32/src/hals/STM32F103/adc.zig: 1 issue
- port/stmicro/stm32/src/hals/STM32F103/i2c.zig: 1 issue
- port/stmicro/stm32/src/hals/common/i2c_v2.zig: 1 issue
- port/stmicro/stm32/src/hals/common/util.zig: 1 issue
- port/texasinstruments/msp430/src/boards/MSP-EXP430F5529LP.zig: 1 issue
- port/texasinstruments/msp430/src/hal/gpio.zig: 2 issues
ℹ️ Additional issues on unchanged lines
The following 32 issue(s) exist but are not on lines changed in this PR:
build-internals/build.zig:125: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
build.zig:329: TODO style comments need to have a linked microzig issue on the same line.
build.zig:8: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
examples/build.zig:25: TODO style comments need to have a linked microzig issue on the same line.
port/raspberrypi/rp2xxx/src/hal/dma.zig:120: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/adc.zig:374: Suggestion: Rename `AdvancedADC` to `Advanced_ADC`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:2: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:309: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/rcc.zig:30: Suggestion: Rename `RccPeriferals` to `RCC_Periferals`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/STM32F103/spi.zig:28: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/uart.zig:1: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F103/uart.zig:2: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/STM32F303/rcc.zig:25: Suggestion: Rename `RccErrorConfig` to `RCC_ErrorConfig`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:69: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:80: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:113: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:13: Suggestion: Rename `I2CError` to `I2C_Error`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/i2c_v2.zig:21: Suggestion: Rename `TimingSpec_Standard` to `TimingSpecStandard`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/timer_v1.zig:169: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/timer_v1.zig:172: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/timer_v1.zig:24: Suggestion: Rename `ARRModes` to `ARR_Modes`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/timer_v1.zig:112: Suggestion: Rename `CCConfig` to `CC_Config`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/timer_v1.zig:173: Suggestion: Rename `GPTimer` to `GP_Timer`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/timer_v1.zig:542: Suggestion: Rename `PWMChConfig` to `PWM_ChConfig`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
port/stmicro/stm32/src/hals/common/uart_v3.zig:82: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:84: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:87: TODO style comments need to have a linked microzig issue on the same line.
port/stmicro/stm32/src/hals/common/uart_v3.zig:229: TODO style comments need to have a linked microzig issue on the same line.
port/wch/ch32v/src/hals/clocks.zig:14: TODO style comments need to have a linked microzig issue on the same line.
port/wch/ch32v/src/hals/clocks.zig:150: TODO style comments need to have a linked microzig issue on the same line.
port/wch/ch32v/src/hals/clocks.zig:173: TODO style comments need to have a linked microzig issue on the same line.
tools/regz/src/gen.zig:421: TODO style comments need to have a linked microzig issue on the same line.
github-actions
bot
dismissed
their stale review
Updating with new lint results
There was a problem hiding this comment.
🔍 Lint Results
Found 3 issues on changed lines in 2 files:
- port/texasinstruments/msp430/src/boards/MSP-EXP430F5529LP.zig: 1 issue
- port/texasinstruments/msp430/src/hal/gpio.zig: 2 issues
ℹ️ Additional issues on unchanged lines
The following 4 issue(s) exist but are not on lines changed in this PR:
build-internals/build.zig:125: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
build.zig:329: TODO style comments need to have a linked microzig issue on the same line.
build.zig:8: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/gen.zig:421: TODO style comments need to have a linked microzig issue on the same line.
Updating with new lint results
There was a problem hiding this comment.
🔍 Lint Results
ℹ️ Additional issues on unchanged lines
The following 4 issue(s) exist but are not on lines changed in this PR:
build-internals/build.zig:125: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
build.zig:329: TODO style comments need to have a linked microzig issue on the same line.
build.zig:8: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/gen.zig:421: TODO style comments need to have a linked microzig issue on the same line.
There was a problem hiding this comment.
🔍 Lint Results
ℹ️ Additional issues on unchanged lines
The following 4 issue(s) exist but are not on lines changed in this PR:
build-internals/build.zig:125: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
build.zig:329: TODO style comments need to have a linked microzig issue on the same line.
build.zig:8: Suggestion: Rename `Cpu` to `CPU`, it _should_ be more in line with our [style guidelines](https://microzig.tech/docs/contributing/). This automation is not perfect so take it with a grain of salt.
tools/regz/src/gen.zig:421: TODO style comments need to have a linked microzig issue on the same line.
Grazfather
reviewed
Jan 4, 2026
Grazfather
approved these changes
Jan 4, 2026
Collaborator
Grazfather
left a comment
Grazfather
left a comment
There was a problem hiding this comment.
Skipped over the regz/sorcerer stuff. Just had a few ideas for debugging improvements, all optional.
tact1m4n3
reviewed
Jan 4, 2026
Copper280z
pushed a commit
to Copper280z/microzig
that referenced
this pull request
Jan 11, 2026
This patch adds two chips and boards, the MSP430F5529, MSP430G2553, and thier Launch Pad boards. My first microcontroller class was taught with an MSP430F5529, so this is very full circle for me. I have these boards on order and will test before merging. There's also a couple more details I need finalized before the merge: - [x] Generate register code from targetdb - [x] Investigate correct compiler and ubsan rt configurations - [x] write blinky example - [x] Implement memset, memcpy, and abort in assembly - [x] Set stack on startup - [x] Create an interrupt vector (fine if it's hardcoded at first) - [x] Map vector table to memory - [x] Add PORT hal - [x] Add watchdog hal - [x] Add external crystals to board Fixes ZigEmbeddedGroup#813
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds two chips and boards, the MSP430F5529, MSP430G2553, and thier Launch Pad boards. My first microcontroller class was taught with an MSP430F5529, so this is very full circle for me. I have these boards on order and will test before merging.
There's also a couple more details I need finalized before the merge:
Fixes #813