Skip to content

feat: Structure tool and prompt-service error handling improvments (for SDK v0.71)#1277

Merged
vishnuszipstack merged 7 commits into
mainfrom
feat/structure-tool-and-prompt-service-err-handling-enhancements
May 9, 2025
Merged

feat: Structure tool and prompt-service error handling improvments (for SDK v0.71)#1277
vishnuszipstack merged 7 commits into
mainfrom
feat/structure-tool-and-prompt-service-err-handling-enhancements

Conversation

@chandrasekharan-zipstack

@chandrasekharan-zipstack chandrasekharan-zipstack commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

What

  • Improvements in structure-tool
  • Prompt service error handling improvements
  • TODO: SDK version bump

Why

  • Helps improve logging and error handling in structure-tool

How

  • Removed some unnecessary logs in structure-tool to make it more concise and effective
  • SDK throws error from prompt-service instead of returning it and required parsing of that response.

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

  • Yes, since it updates the behaviour of the SDK methods involving prompt-service however all usages have been replaced

Related Issues or PRs

Notes on Testing

  • Tested locally along with other changes

Screenshots

Checklist

I have read and understood the Contribution Guidelines.

@chandrasekharan-zipstack chandrasekharan-zipstack changed the title WIP: Structure tool and prompt-service error handling improvments WIP: Structure tool and prompt-service error handling improvments (for SDK v0.71) Apr 29, 2025

@harini-venkataraman harini-venkataraman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please bump tool version.

@chandrasekharan-zipstack chandrasekharan-zipstack changed the title WIP: Structure tool and prompt-service error handling improvments (for SDK v0.71) feat: Structure tool and prompt-service error handling improvments (for SDK v0.71) May 9, 2025
@github-actions

github-actions Bot commented May 9, 2025

Copy link
Copy Markdown
Contributor
filepath function $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_logs}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_cleanup\_skip}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_client\_init}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image\_exists}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_container\_run\_config\_without\_mount}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_run\_container}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_get\_image\_for\_sidecar}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{runner/src/unstract/runner/clients/test\_docker.py}}$$ $$\textcolor{#23d18b}{\tt{test\_sidecar\_container}}$$ $$\textcolor{#23d18b}{\tt{1}}$$ $$\textcolor{#23d18b}{\tt{1}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{11}}$$ $$\textcolor{#23d18b}{\tt{11}}$$

@sonarqubecloud

sonarqubecloud Bot commented May 9, 2025

Copy link
Copy Markdown

@vishnuszipstack vishnuszipstack merged commit 35ce560 into main May 9, 2025
@vishnuszipstack vishnuszipstack deleted the feat/structure-tool-and-prompt-service-err-handling-enhancements branch May 9, 2025 10:50
pk-zipstack pushed a commit that referenced this pull request Aug 20, 2025
…or SDK v0.71) (#1277)

* feat: Structure tool and prompt-service error handling improvments

* deps: Bumped SDK version

* deps: Removed sdk from dev group since its already in the main list of deps

* Commit uv.lock changes

* deps: Updated tool versions

* deps: Updated tool versions

---------

Signed-off-by: Chandrasekharan M <117059509+chandrasekharan-zipstack@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants