[FIX] Revert cell type merge - Table#1297
Merged
Merged
Conversation
harini-venkataraman
requested review from
Deepak-Kesavan,
gaya3-vijayakumar and
hari-kuriakose
hari-kuriakose
left a comment
hari-kuriakose
left a comment
Contributor
There was a problem hiding this comment.
@harini-venkataraman Migration looks good overall.
Please check the comments though.
gaya3-vijayakumar
approved these changes
May 10, 2025
gaya3-vijayakumar
left a comment
gaya3-vijayakumar
left a comment
Contributor
There was a problem hiding this comment.
Looks safe to me.
Contributor
|
|
Deepak-Kesavan
approved these changes
May 10, 2025
pk-zipstack
pushed a commit
that referenced
this pull request
Aug 20, 2025
* Reverting Cell type merge * FE fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR to revert line-item and rename it to table.
...
Why
To handle more complex use cases, the product decision was made to keep it in the previous version and inherit verticals logic to address complex use cases.
...
How
Reverting the new changes.
...
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Yes, the PR will change the line-item rename into old version - Cell type
...
Database Migrations
Yes includes data migration.
...
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Tested migrations and newly created project, and exisiting project.
...
Screenshots
Checklist
I have read and understood the Contribution Guidelines.