Optimization and fix of file execution - parallel execution#1326
Merged
chandrasekharan-zipstack merged 14 commits intoMay 27, 2025
Conversation
muhammad-ali-e
requested review from
chandrasekharan-zipstack,
gaya3-vijayakumar,
harini-venkataraman,
ritwik-g and
vishnuszipstack
…com:Zipstack/unstract into fix/duplicate-file-hash-for-api-deployement
muhammad-ali-e
changed the title
muhammad-ali-e
changed the title
…com:Zipstack/unstract into fix/duplicate-file-hash-for-api-deployement
ritwik-g
reviewed
May 23, 2025
chandrasekharan-zipstack
approved these changes
May 23, 2025
pk-zipstack
approved these changes
May 23, 2025
vishnuszipstack
approved these changes
May 23, 2025
pk-zipstack
approved these changes
May 23, 2025
gaya3-vijayakumar
approved these changes
May 27, 2025
gaya3-vijayakumar
left a comment
gaya3-vijayakumar
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Quick glance.
Contributor
|
|
chandrasekharan-zipstack
deleted the
fix/duplicate-file-hash-for-api-deployement
branch
pk-zipstack
pushed a commit
that referenced
this pull request
Aug 20, 2025
* skip the duplicates when list files by hash * refactored _get_matched_files method to reduce complexity * remove making of content filehash from the source list files * reduce complexity of get_matched_files methode * added file limit log to viisbility for debugging * added one more logs while starting file process * added logs, removed unrequired pass, updated filehistory condition --------- Co-authored-by: Gayathri <142381512+gaya3-zipstack@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
file hash, even if the file names differ.file processing initialization( this is a safety net for scenarios that shouldn't normally occur.).file hashesfromfsspec metadata(instead of computingcontent hashes) for source connectors during file listing (ETL/TASK).fsspec API calls—now uses a singlelistdircall to retrievemetadatamore efficiently.checksumfield).Why
How
file hashobtained frommetadataorcontent hashCan this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.