UN-2315 [FEAT] Added frontend error handling for GDrive input/output connectors in workflow settings#1464
Merged
Merged
Conversation
Contributor
Summary by CodeRabbit
WalkthroughThis set of changes implements connector-specific OAuth state management and persistent selection in the frontend. It introduces localStorage keys scoped per connector for OAuth credentials and status, updates the logic for enabling/disabling UI elements based on connector state, and ensures selected items persist across sessions. Backend cache behavior for OAuth credentials is also adjusted. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ConfigureDs
participant OAuthDs
participant LocalStorage
participant Backend
User->>ConfigureDs: Selects connector (SOURCE/DESTINATION)
ConfigureDs->>LocalStorage: Load OAuth state for connector/role
ConfigureDs->>OAuthDs: Pass connector-specific props and setters
User->>OAuthDs: Initiates OAuth flow
OAuthDs->>Backend: Start OAuth, receive cache key
OAuthDs->>LocalStorage: Store cache key and status with connector-specific key
OAuthDs->>ConfigureDs: Update state with cache key/status
User->>ConfigureDs: Submits form
ConfigureDs->>LocalStorage: Persist OAuth state for connector/role
sequenceDiagram
participant User
participant InputOutput
participant LocalStorage
User->>InputOutput: Opens Input/Output page
InputOutput->>LocalStorage: Retrieve last selected item
InputOutput->>User: Display selected item
User->>InputOutput: Selects new item
InputOutput->>LocalStorage: Save selected item
User->>InputOutput: Deletes selected item
InputOutput->>LocalStorage: Remove selected item entry
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~18 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
chandrasekharan-zipstack
left a comment
chandrasekharan-zipstack
left a comment
Contributor
There was a problem hiding this comment.
BE changes LGTM.
@kirtimanmishrazipstack why do we need to store this in cache if the test connection succeeds? I think it should be safe to delete it from the cache in that case - try to perform this just to be safe
vishnuszipstack
approved these changes
Jul 31, 2025
chandrasekharan-zipstack
approved these changes
Aug 4, 2025
Contributor
|
@kirtimanmishrazipstack check the sonar issue and try to resolve that. |
Contributor
|
|
pk-zipstack
pushed a commit
that referenced
this pull request
Aug 20, 2025
…connectors in workflow settings (#1464) * FE gdrive changes * FE gdrive changes * FE gdrive changes * FE gdrive changes * adding .gitignore * small documentation --------- Co-authored-by: vishnuszipstack <117254672+vishnuszipstack@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.