Skip to content

Fix:decrypt connector metatada #18

Merged
nehabagdia merged 9 commits into
mainfrom
fix/connector-get-instance-bug
Feb 29, 2024
Merged

Fix:decrypt connector metatada #18
nehabagdia merged 9 commits into
mainfrom
fix/connector-get-instance-bug

Conversation

@kirtimanmishrazipstack

@kirtimanmishrazipstack kirtimanmishrazipstack commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

What

  • connector_metadata field encryption on connector_instance model

Why

  • since we access the connector_metadata at several places in the code, we will be forced to encrpyt / decrypt on model itself

How

  • Used django model methods
  • Added custom method metatdata with @Property to decrypt connector_metatdata_b
  • At all places where we were using connector_instance.connector_metatdata, replaced that with `connector_instance.metatdata'

Relevant Docs

Related Issues or PRs

Dependencies Versions / Env Variables

Notes on Testing

...

Screenshots

Screenshot from 2024-02-29 13-42-10
Screenshot from 2024-02-29 13-41-21

Checklist

I have read and understood the Contribution Guidelines.

@kirtimanmishrazipstack kirtimanmishrazipstack changed the title fixing connector metadata by decrypting Fix:decrypt connector metatada Feb 29, 2024
@kirtimanmishrazipstack
kirtimanmishrazipstack marked this pull request as ready for review February 29, 2024 08:39
Comment thread backend/workflow_manager/endpoint/destination.py

@johnyrahul johnyrahul left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@chandrasekharan-zipstack chandrasekharan-zipstack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, also it has to be handled for other apps - adapter_processor and connector_auth as well

Comment thread backend/connector/models.py
@nehabagdia
nehabagdia merged commit 513f704 into main Feb 29, 2024
@nehabagdia
nehabagdia deleted the fix/connector-get-instance-bug branch February 29, 2024 09:49
pk-zipstack pushed a commit that referenced this pull request Aug 20, 2025
* fixing connector metadata by decrypting

* mypy resolve prompt studio

* reverting old FE changes to get connector metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants