UN-3699 [FIX] Fix runner DockerException with requests>=2.32 by bumping docker-py to 7.1.0#2155
Merged
Merged
Conversation
docker-py 6.1.3 is incompatible with requests>=2.32: its UnixHTTPAdapter only overrides the old get_connection path, so requests 2.32+ (locked at 2.33.0 via unstract-core) routes the internal http+docker:// socket URL to urllib3, raising URLSchemeUnknown -> DockerException at DockerClient.from_env(). This breaks any runner image rebuilt from main on the Docker container-client path (cloud/k8s is unaffected — it never calls from_env). Bump docker to 7.1.0, which handles requests>=2.32. Leaves the org-wide requests==2.33.0 untouched (lowering it is unsatisfiable: workers and x2text-service require >=2.33.0). Runner uses only stable high-level docker APIs; websocket-client drops out as it is now an optional docker extra and the runner uses no websocket features. Verified: docker 7.1.0 + requests 2.33.0 -> DockerClient.from_env().ping() == True against a real socket. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThe ChangesDependency Update
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
chandrasekharan-zipstack
approved these changes
Jul 8, 2026
|
Contributor
Unstract test resultsPer-group results
Critical paths
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
docker(docker-py) pin from6.1.3to7.1.0and regeneraterunner/uv.lock.Why
runnerimage rebuilt from currentmainon the Docker container-client path crashes atDockerClient.from_env()with:docker.errors.DockerException: Error while fetching server API version: Not supported URL scheme http+docker6.1.3is incompatible withrequests>=2.32. A dependabot bump raised the transitiverequeststo2.33.0(hard-pinned==2.33.0byunstract-core; also required>=2.33.0byworkers/x2text-service). docker-py'sUnixHTTPAdapteronly overrides the oldget_connection; requests 2.32+ walksget_connection_with_tls_context, so the internalhttp+docker://socket URL reaches urllib3 →URLSchemeUnknown→InvalidURL.from_env(); other devs run older published runner images baked withrequests<2.32. It is a latent bug onmainfor anyone who rebuilds runner.requestsis unsatisfiable (other services require>=2.33.0), so the fix bumps the stale consumer instead.How
runner/pyproject.toml:docker==6.1.3→docker==7.1.0.runner/uv.lock: regenerated — docker updated;websocket-clientdrops out (it is now an optional docker extra and the runner uses no websocket features).Can this PR break any existing features. If yes, please list possible items. If no, please explain why.
containers.run/containers.get,images.get,api.pull,container.logs(follow=True)), all unchanged in docker-py 7.x. It uses noexec_run/attach/ websocket features, so droppingwebsocket-clientis safe. The Kubernetes container-client path is untouched.Database Migrations
Env Config
Relevant Docs
requests>=2.32compatibility).Related Issues or PRs
Dependencies Versions
docker(docker-py):6.1.3→7.1.0Notes on Testing
docker 7.1.0 + requests 2.33.0→DockerClient.from_env().ping() == Trueagainst a real Docker socket; the runner boots and spawns tool containers again.Screenshots
Checklist
I have read and understood the Contribution Guidelines.
🤖 Generated with Claude Code