Remove absolute paths used in pdm.lock file#29
Merged
Conversation
* Fix local dependency path for backend pdm lock file
hari-kuriakose
requested review from
Deepak-Kesavan,
chandrasekharan-zipstack and
muhammad-ali-e
February 29, 2024 16:16
muhammad-ali-e
approved these changes
Feb 29, 2024
jaseemjaskp
self-requested a review
March 1, 2024 05:06
nehabagdia
approved these changes
Mar 1, 2024
jaseemjaskp
approved these changes
Mar 1, 2024
pk-zipstack
pushed a commit
that referenced
this pull request
Aug 20, 2025
* Remove unnecessary pdm lock file for tool registry * Fix local dependency path for backend pdm lock file Co-authored-by: Neha <115609453+nehabagdia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pdm.lockfile for backendpdm.lockfile for backendpdm.lockfile for tool registry as it will always be a local dependencyWhy
Indirect local dependencies usually need to be added in their own projects as: https://pdm-project.org/latest/usage/dependency/#local-dependencies.
However, such indirect local dependencies which are not direct dependency of main project appear as absolute paths in
pdm.lockof main project, making it impossible to check in the lock file.How
backend).tool-registry).pdm.lockfile in the main project without using any absolute paths.Notes on Testing
New generated
pdm.lockfile for backend does not contain any absolute paths.Checklist
I have read and understood the Contribution Guidelines.