Fix/file upload security#31
Merged
Merged
Conversation
…k/unstract into fix/file_upload_security
gaya3-vijayakumar
requested review from
Deepak-Kesavan,
jaags-dev,
jaseemjaskp,
kirtimanmishrazipstack,
nehabagdia and
tahierhussain
February 29, 2024 16:42
muhammad-ali-e
left a comment
muhammad-ali-e
left a comment
Contributor
There was a problem hiding this comment.
LGTM for the functionality. Minor coments are added.
nehabagdia
approved these changes
Mar 1, 2024
jaags-dev
approved these changes
Mar 1, 2024
pk-zipstack
pushed a commit
that referenced
this pull request
Aug 20, 2025
* Add file upload validation * Code formatting * Code formatting * Change values to constants * Remove unwanted import * Set file pointer to the beginning of the file * Set pointer to the beginning of the file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Validation is reading a few bytes to understand the mime type and the file pointer is not reset. Because of this bytes are lost
How
Reset the file pointer to the start of the file
Relevant Docs
Related Issues or PRs
Dependencies Versions / Env Variables
Notes on Testing
...
Screenshots
...
Checklist
I have read and understood the Contribution Guidelines.