Add optional docker services#42
Merged
Merged
Conversation
* Update readme
hari-kuriakose
requested review from
chandrasekharan-zipstack,
jaseemjaskp,
muhammad-ali-e and
ritwik-g
March 1, 2024 18:19
chandrasekharan-zipstack
approved these changes
Mar 2, 2024
chandrasekharan-zipstack
left a comment
chandrasekharan-zipstack
left a comment
Contributor
There was a problem hiding this comment.
LGTM - but we do need to check if we handle the error properly when the service is not run and a user tries to create an unstructured community adapter
nehabagdia
approved these changes
Mar 2, 2024
pk-zipstack
pushed a commit
that referenced
this pull request
Aug 20, 2025
* Add optional docker services * Update readme Co-authored-by: Neha <115609453+nehabagdia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
optionalprofile for services in docker composeWhy
Some docker services need to be kept optional and thus not started by default.
For example,
unstructured-iowhich has image size of 17GB. Users can choose to run this if they wish.How
VERSION=dev docker compose -f docker-compose.yaml up -dwill not run optional services.VERSION=dev docker compose -f docker-compose.yaml --profile optional up -dwill run everything including optional services.Notes on Testing
Verified that on passing
--profile optionalunstructured-io service is started, otherwise not.Checklist
I have read and understood the Contribution Guidelines.