Skip to content

fix: Prompt-service issue for 0 chunk size#50

Merged
hari-kuriakose merged 1 commit into
mainfrom
fix/promt-service-fix-for-0-chunk-size
Mar 4, 2024
Merged

fix: Prompt-service issue for 0 chunk size#50
hari-kuriakose merged 1 commit into
mainfrom
fix/promt-service-fix-for-0-chunk-size

Conversation

@chandrasekharan-zipstack

Copy link
Copy Markdown
Contributor

What

  • Updated prompt-service's usage of ToolIndex.get_text_from_index() from the SDK

Why

  • The function was not updated after some breaking changes were made in the SDK
  • This caused an issue when chunk size was 0

How

Relevant Docs

Related Issues or PRs

Dependencies Versions / Env Variables

Notes on Testing

  • Tried to generate responses from LLM when chunk size was 0

Screenshots

image

Checklist

I have read and understood the Contribution Guidelines.

Comment thread prompt-service/src/unstract/prompt_service/main.py

@gaya3-vijayakumar gaya3-vijayakumar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@hari-kuriakose hari-kuriakose left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hari-kuriakose
hari-kuriakose merged commit 09f1732 into main Mar 4, 2024
@hari-kuriakose
hari-kuriakose deleted the fix/promt-service-fix-for-0-chunk-size branch March 4, 2024 07:37
pk-zipstack pushed a commit that referenced this pull request Aug 20, 2025
Fixed prompt-service for 0 chunk size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants