Mistral large model support & error handling fix#52
Merged
Conversation
…k/unstract into fix/file_upload_security
…ew fix for FileValidation.py
chandrasekharan-zipstack
requested changes
Mar 4, 2024
chandrasekharan-zipstack
left a comment
chandrasekharan-zipstack
left a comment
Contributor
There was a problem hiding this comment.
Please address my error handling concerns around testing adapters.
NIT: Also there's duplication of logic between the backend and SDK. The SDK does perform these validations for tools in a worfklow and I understand we're doing this validation for prompt studio - we could try to refactor and reuse logic wherever possible
athul-rs
approved these changes
Mar 4, 2024
athul-rs
left a comment
athul-rs
left a comment
Contributor
There was a problem hiding this comment.
@chandrasekharan-zipstack @muhammad-ali-e Please take a look into file validator file before merging, I have minimum context here.
Rest LGTM.
chandrasekharan-zipstack
self-requested a review
March 4, 2024 14:24
chandrasekharan-zipstack
approved these changes
Mar 4, 2024
chandrasekharan-zipstack
self-requested a review
March 4, 2024 14:27
gaya3-vijayakumar
changed the title
gaya3-vijayakumar
changed the title
… dependency files
hari-kuriakose
approved these changes
Mar 5, 2024
hari-kuriakose
left a comment
hari-kuriakose
left a comment
Contributor
There was a problem hiding this comment.
@gaya3-zipstack LGTM overall.
Added few comments though.
mohamed-siddhiq
pushed a commit
that referenced
this pull request
Mar 7, 2024
* Add file upload validation * Code formatting * Change values to constants * Set file pointer to the beginning of the file * Change exception handling to report adapter error properly, Code review fix for FileValidation.py * Revert special JSON handling * Version upgrade of adapters & sdk. Update .gitignore to exclude local dependency files * Updating SDK version for added support of large models in Mistral --------- Co-authored-by: Hari John Kuriakose <hari@zipstack.com>
pk-zipstack
pushed a commit
that referenced
this pull request
Aug 20, 2025
* Add file upload validation * Code formatting * Change values to constants * Set file pointer to the beginning of the file * Change exception handling to report adapter error properly, Code review fix for FileValidation.py * Revert special JSON handling * Version upgrade of adapters & sdk. Update .gitignore to exclude local dependency files * Updating SDK version for added support of large models in Mistral --------- Co-authored-by: Hari John Kuriakose <hari@zipstack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
How
Relevant Docs
Related Issues or PRs
Dependencies Versions / Env Variables
Notes on Testing
...
Screenshots
Checklist
I have read and understood the Contribution Guidelines.