Skip to content

Fix for UI issues in workflow page#58

Merged
hari-kuriakose merged 4 commits into
mainfrom
fix/Workflow-front-end-issues
Mar 5, 2024
Merged

Fix for UI issues in workflow page#58
hari-kuriakose merged 4 commits into
mainfrom
fix/Workflow-front-end-issues

Conversation

@mohamed-siddhiq

Copy link
Copy Markdown
Contributor

What

Covers the below bug fixes,

  • If a workflow is used in API/ETL/Task pipelines - should not allow to delete & change the Source/Destination endpoints
  • Restrict the Workflow Destination endpoint dropdown to show only relevant options based on the values selected in Source endpoint. ( ie: When API is selected in Source endpoint, we should show only API in destination endpoint dropdown)
  • Enable Deploy as API/ETL/Task pipeline options in workflow only when the Source & Destinations are configured.

Why

...

How

...

Relevant Docs

Related Issues or PRs

Dependencies Versions / Env Variables

Notes on Testing

...

Screenshots

...

Checklist

I have read and understood the Contribution Guidelines.

@athul-rs athul-rs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohamed-siddhiq Please refer the comments left.

Comment thread backend/workflow_manager/workflow/views.py Outdated
Comment thread frontend/src/components/agency/ds-settings-card/DsSettingsCard.jsx
Comment thread frontend/src/components/agency/ds-settings-card/DsSettingsCard.jsx

@tahierhussain tahierhussain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@athul-rs athul-rs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The review comments are all addressed.

@hari-kuriakose
hari-kuriakose merged commit 22a0c58 into main Mar 5, 2024
@hari-kuriakose
hari-kuriakose deleted the fix/Workflow-front-end-issues branch March 5, 2024 10:02
mohamed-siddhiq added a commit that referenced this pull request Mar 7, 2024
* Fix for UI issues in workflow page

* Addressed review comments

---------

Co-authored-by: Hari John Kuriakose <hari@zipstack.com>
Co-authored-by: Athul <89829560+athul-rs@users.noreply.github.com>
pk-zipstack pushed a commit that referenced this pull request Aug 20, 2025
* Fix for UI issues in workflow page

* Addressed review comments

---------

Co-authored-by: Hari John Kuriakose <hari@zipstack.com>
Co-authored-by: Athul <89829560+athul-rs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants