Skip to content

fix: Prompt studio tool delete fix#7

Merged
jaseemjaskp merged 1 commit intomainfrom
fix/prompt-studio-tool-delete-for-unexported-tools
Feb 27, 2024
Merged

fix: Prompt studio tool delete fix#7
jaseemjaskp merged 1 commit intomainfrom
fix/prompt-studio-tool-delete-for-unexported-tools

Conversation

@chandrasekharan-zipstack
Copy link
Copy Markdown
Contributor

What

  • Made the dependent workflow check during prompt studio tool deletion conditional

Why

  • Facing an issue where prompt studio tools which are not exported were not deleted
    image

How

  • We check if the CustomTool instance has a 1:1 relationship with PromptStudioRegistry

Relevant Docs

Related Issues or PRs

Dependencies Versions / Env Variables

Notes on Testing

  • Tried deleting prompt studio tools which are exported and ones which were newly created

Screenshots

  • No regression
    image
  • Prompt studio tool deleted
    image

Checklist

I have read and understood the Contribution Guidelines.

@harini-venkataraman
Copy link
Copy Markdown
Contributor

LGTM

@jaseemjaskp jaseemjaskp self-requested a review February 27, 2024 09:37
@jaseemjaskp jaseemjaskp merged commit 5d428ff into main Feb 27, 2024
@jaseemjaskp jaseemjaskp deleted the fix/prompt-studio-tool-delete-for-unexported-tools branch February 27, 2024 09:38
pk-zipstack pushed a commit that referenced this pull request Aug 20, 2025
…-unexported-tools

fix: Prompt studio tool delete fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants