Skip to content

fix: Prompt studio tool delete fix #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaseemjaskp merged 1 commit into from
Feb 27, 2024
Merged

fix: Prompt studio tool delete fix #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 17 additions & 15 deletions backend/prompt_studio/prompt_studio_core/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from rest_framework.versioning import URLPathVersioning
from tool_instance.models import ToolInstance
from utils.filtering import FilterHelper
from prompt_studio.prompt_studio_registry.models import PromptStudioRegistry

from .models import CustomTool
from .serializers import CustomToolSerializer, PromptStudioIndexSerializer
Expand Down Expand Up @@ -74,22 +75,23 @@ def destroy(
self, request: Request, *args: tuple[Any], **kwargs: dict[str, Any]
) -> Response:
instance: CustomTool = self.get_object()
exported_tool_instances_in_use = ToolInstance.objects.filter(
tool_id__exact=instance.prompt_studio_registry.pk
)
dependent_wfs = set()
for tool_instance in exported_tool_instances_in_use:
dependent_wfs.add(tool_instance.workflow_id)
if len(dependent_wfs) > 0:
logger.info(
f"Cannot destroy custom tool {instance.tool_id},"
f" depended by workflows {dependent_wfs}"
)
raise ToolDeleteError(
"Failed to delete tool, its used in other workflows. "
"Delete its usages first"
# Checks if tool is exported
if hasattr(instance, "prompt_studio_registry"):
exported_tool_instances_in_use = ToolInstance.objects.filter(
tool_id__exact=instance.prompt_studio_registry.pk
)

dependent_wfs = set()
for tool_instance in exported_tool_instances_in_use:
dependent_wfs.add(tool_instance.workflow_id)
if len(dependent_wfs) > 0:
logger.info(
f"Cannot destroy custom tool {instance.tool_id},"
f" depended by workflows {dependent_wfs}"
)
raise ToolDeleteError(
"Failed to delete tool, its used in other workflows. "
"Delete its usages first"
)
return super().destroy(request, *args, **kwargs)

@action(detail=True, methods=["get"])
Expand Down