Skip to content

Fix/prompt-studio-UI {Adding new suggestions}#73

Merged
nehabagdia merged 4 commits into
mainfrom
fix/prompt-studio-bugFix-Mar07
Mar 9, 2024
Merged

Fix/prompt-studio-UI {Adding new suggestions}#73
nehabagdia merged 4 commits into
mainfrom
fix/prompt-studio-bugFix-Mar07

Conversation

@athul-rs

@athul-rs athul-rs commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

What

Prompt-Studio UI changes:

Added additional improvements on prompt part :

Why

...

How

...

Relevant Docs

Related Issues or PRs

Dependencies Versions / Env Variables

Notes on Testing

...

Screenshots

...

Checklist

I have read and understood the Contribution Guidelines.

@athul-rs athul-rs changed the title Fix/prompt-studio-UI Fix/prompt-studio-UI {Adding new suggestions} Mar 8, 2024
@athul-rs
athul-rs marked this pull request as draft March 8, 2024 04:42
@athul-rs
athul-rs requested a review from hari-kuriakose March 8, 2024 04:42

@tahierhussain tahierhussain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@athul-rs Can you please add the invalid JSON error in the helper text, instead of displaying it in the popup? Also, can you please address @shuveb's request in the comments?

@athul-rs

athul-rs commented Mar 8, 2024

Copy link
Copy Markdown
Contributor Author

@athul-rs Can you please add the invalid JSON error in the helper text, instead of displaying it in the popup? Also, can you please address @shuveb's request in the comments?

Already Added.

@athul-rs
athul-rs marked this pull request as ready for review March 8, 2024 11:26
@athul-rs
athul-rs requested a review from tahierhussain March 8, 2024 11:26
Comment thread frontend/src/components/custom-tools/editable-text/EditableText.jsx Outdated
Comment thread frontend/src/components/custom-tools/tool-ide/ToolIde.jsx

@tahierhussain tahierhussain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@athul-rs athul-rs self-assigned this Mar 8, 2024

@hari-kuriakose hari-kuriakose left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@athul-rs LGTM overall.

@nehabagdia
nehabagdia merged commit 961e5a3 into main Mar 9, 2024
@nehabagdia
nehabagdia deleted the fix/prompt-studio-bugFix-Mar07 branch March 9, 2024 15:18
pk-zipstack pushed a commit that referenced this pull request Aug 20, 2025
* Fix/prompt-studio UN-920 UN-919 UN-921

* Fix/prompt-studio improvements

* Fix/prompt-studio log prompt-studio revert

* Fix/prompt-studio timeout correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants