feat(auth): integrate LoginPage and RegisterPage with API client - #2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the frontend auth flow to use the shared apiClient (calling real backend /auth/login and /auth/register) and refactors AppContext auth helpers to accept a user object instead of validating credentials client-side.
Changes:
- Wire
LoginPageandRegisterPagetoapiClient.login()/apiClient.register()and log the user in on success. - Refactor
AppContext.loginto dispatch a user payload directly (and remove the old in-memory credential check/register helper). - Update the login demo credentials shown on the page.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| frontend/src/app/pages/RegisterPage.tsx | Uses apiClient.register() then calls AppContext.login() with returned user fields; adds error handling. |
| frontend/src/app/pages/LoginPage.tsx | Uses apiClient.login() then calls AppContext.login(); updates demo credentials display. |
| frontend/src/app/context/AppContext.tsx | Changes login signature to accept a user object and removes the previous local credential-based login/register logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+41
to
+47
| const response = await apiClient.register(form.name.trim(), form.email, form.password); | ||
| login({ | ||
| id: response.data.id, | ||
| name: response.data.name, | ||
| email: response.data.email, | ||
| role: response.data.role as "admin" | "member", | ||
| }); |
Comment on lines
+50
to
+54
| } catch (error: any) { | ||
| toast.error(error.message || "Registration failed"); | ||
| if (error.message.includes("email")) { | ||
| setErrors((p) => ({ ...p, email: error.message })); | ||
| } |
Comment on lines
+32
to
+38
| const response = await apiClient.login(email, password); | ||
| login({ | ||
| id: response.data.id, | ||
| name: response.data.name, | ||
| email: response.data.email, | ||
| role: response.data.role as "admin" | "member", | ||
| }); |
Comment on lines
+41
to
+42
| } catch (error: any) { | ||
| toast.error(error.message || "Invalid email or password"); |
Comment on lines
+282
to
+287
| function login(user: Omit<User, "avatar" | "password">): void { | ||
| const loginUser: User = { | ||
| ...user, | ||
| avatar: undefined, | ||
| }; | ||
| dispatch({ type: "LOGIN", payload: loginUser }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.