Fix rendering non-form annotations #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As for "why"... there was a behavior change made in the native PDFium lib some time ago to correct the confusing behavior of those render/draw functions. This happened after the original PDFiumSharp project was authored by @ArgusMagnus. Details here: https://codereview.chromium.org/2323203002 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not exactly sure why it was done like this in the first place (my guess is it was assumed that
FPDF_RenderPageBitmapandFPDF_FFLDrawrender the exact same annotations), but according to documentation FPDF_RenderPageBitmap renders everything except widgets and popups, while FPDF_FFLDraw only renders widgets and popups. Which is why we have to passRenderingFlags.Annotationsflag to the both of them.