Security: validate path-segment identifiers (path injection)#122
Merged
Conversation
…tion URIBuilder.setPath percent-encodes everything except '/', so a user or group id containing a path separator could inject extra URL path segments. Nextcloud identifiers cannot legitimately contain a separator, so reject '/' and '\' in the identifiers used as path segments (ProvisionConnector user/group ops and GroupFolders group names) via a shared requireValidPathSegment helper. Adds ConnectorCommonTest for the helper. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the low-severity path-injection finding from the security review.
URIBuilder.setPathpercent-encodes every reserved character except/, so a user/group identifier containing a path separator could inject extra URL path segments (e.g.admin/../otheruser). Nextcloud identifiers cannot legitimately contain a separator.Fix: a shared
ConnectorCommon.requireValidPathSegmenthelper rejects/and\(and null), applied to the identifiers used as URL path segments inProvisionConnector(user/group operations) andGroupFolders(group names).ConfigConnectoris intentionally left as-is since it exposes a deliberateapp/keypath-based API.Adds
ConnectorCommonTest; the integration suite (which uses valid ids) confirms no regression.🤖 Generated with Claude Code