fix: quote $BASEDIR in launcher scripts to support paths with spaces#178
Merged
iaik-jheher merged 1 commit intoJul 22, 2026
Merged
Conversation
The macOS and Linux launcher scripts fail when the application is installed on a path containing spaces (e.g. /Volumes/External Apps/). The unquoted $BASEDIR variable undergoes word splitting, causing the shell to interpret the path fragment before the space as the executable name, resulting in 'No such file or directory'. Fix by quoting "$BASEDIR/jre/bin/java" in both scripts. Also modernize the Linux script to use $(dirname ...) with proper quoting instead of backticks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The macOS and Linux launcher scripts fail when the application is installed on a path containing spaces (e.g.
/Volumes/External Apps/).The unquoted
$BASEDIRvariable undergoes word splitting, causing the shell to interpret the path fragment before the space as the executable name:Fix
"$BASEDIR/jre/bin/java"in bothpdf-over_mac.shandpdf-over_linux.sh$(dirname ...)with proper quoting instead of backticksTesting
Verified on macOS (Apple Silicon) with the app located at
/Volumes/External Apps/External Applications/PDF-Over.app— the app now launches successfully.