fix(otel-it): remove dead CDI alternative and refresh stale integration-tests docs - #1016
Closed
ez-lbz wants to merge 5 commits into
Closed
fix(otel-it): remove dead CDI alternative and refresh stale integration-tests docs#1016ez-lbz wants to merge 5 commits into
ez-lbz wants to merge 5 commits into
Conversation
…ive from beans.xml The class was removed in a refactor but the beans.xml alternative still references it, leaving invalid CDI config that can fail deployment under strict containers.
…porter wiring explicit The README described components and tests that no longer exist and listed known issues that are already resolved. The in-memory span exporter was only picked up via the Quarkus default, which is fragile; configure the cdi exporter explicitly.
The SDK and examples target Java 17, but the READMEs still claimed Java 11 or higher.
testSubscribeToTerminalTaskError waits only 10s for the expected UnsupportedOperationError; under a fully-loaded CI runner the SSE error delivery can exceed that window and the test fails spuriously. Widen the wait to 30s and count down on a clean stream completion so a missing error fails fast with a precise assertion instead of a timeout.
This was referenced Aug 7, 2026
Collaborator
|
Thanks, but #1019 superseded it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
1. Remove non-existent
InstrumentedRequestHandleralternative frombeans.xmlProblem:
extras/opentelemetry/integration-tests/src/main/resources/META-INF/beans.xmldeclaredorg.a2aproject.sdk.extras.opentelemetry.it.InstrumentedRequestHandleras a CDI alternative, but that classno longer exists in the module — a leftover from an earlier test design. The beans.xml therefore declares an
alternative that cannot be resolved: invalid CDI configuration that fails deployment under strict containers
(e.g. Weld), and dead config that misleads anyone reading the module.
Fix (beans.xml):
<alternatives>block; the file now only declaresbean-discovery-mode="all".2. Update stale OpenTelemetry integration-tests README and make span exporter wiring explicit
Problem:
extras/opentelemetry/integration-tests/README.mddescribed components and tests that no longerexist (
SimpleAgent,AgentResource,InstrumentedRequestHandler,OpenTelemetryProducer,OpenTelemetryIntegrationTest,OpenTelemetryTracingTest) and a "Known Issues" section claiming tests timeout on message send and that
InMemorySpanExporterdoes not find expected spans — none of which reproducetoday (the module tests pass and spans are exported correctly). The span exporter was also only wired through
the Quarkus default (
cdi), so the test harness's reliance on the in-memory exporter was implicit and easy tobreak.
Fix (A2ATestRoutes / application.properties):
SimpleAgentExecutor,A2ATestRoutes,TestUtilsBean,TestAgentCardProducer, and the three test classes (OpenTelemetryA2ATest,OpenTelemetryA2AIT,OpenTelemetryTest); dropped the resolved "Known Issues".quarkus.otel.traces.exporter=cdiexplicitly in bothsrc/main/resources/application.propertiesandsrc/test/resources/application.properties, so the CDIInMemorySpanExporterbean is selected explicitlyinstead of by default.
3. Correct required Java version in helloworld example READMEs
Problem:
examples/helloworld/server/README.mdandexamples/helloworld/client/README.mdstated"Java 11 or higher", but the SDK and both examples target Java 17 (parent pom sets
maven.compiler.release=17); users following the README with Java 11 would fail to build/run.Fix (helloworld READMEs):
Testing
after the changes.
mvn verify -pl extras/opentelemetry/integration-tests— all 9 tests pass:OpenTelemetryA2ATest(4) andOpenTelemetryTest(1) in@QuarkusTest(JVM) mode;OpenTelemetryA2AIT(4) in@QuarkusIntegrationTest(packaged) mode.
GetTask/ListTasks/CancelTaskSERVER spans with the expected attributesreach
InMemorySpanExportervia/export.Behavior change: none — the fixes are config/docs only; the explicit
cdiexporter is the same effectivebehavior as the previous implicit default.