Skip to content

fix: Use HasField for simple message retrieval for grpc transport #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 4, 2025
+24 −2
Merged

fix: Use HasField for simple message retrieval for grpc transport #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85bcf6f
fix: Use HasField for simple message retrieval for grpc transport
timn Aug 4, 2025
545acd3
feat: Add test for send_message that returns a Message
timn Aug 4, 2025
9b17a81
Merge branch 'main' into timn/fix-grpc-sendmessage-result
pstephengoogle Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/a2a/client/transports/grpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ async def send_message(
metadata=proto_utils.ToProto.metadata(request.metadata),
)
)
if response.task:
if response.HasField('task'):
return proto_utils.FromProto.task(response.task)
return proto_utils.FromProto.message(response.msg)

Expand Down
24 changes: 23 additions & 1 deletion tests/client/test_grpc_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
TaskStatus,
TextPart,
)
from a2a.utils import proto_utils
from a2a.utils import get_text_parts, proto_utils


# Fixtures
Expand Down Expand Up @@ -112,6 +112,28 @@ async def test_send_message_task_response(
assert response.id == sample_task.id


@pytest.mark.asyncio
async def test_send_message_message_response(
grpc_transport: GrpcTransport,
mock_grpc_stub: AsyncMock,
sample_message_send_params: MessageSendParams,
sample_message: Message,
):
"""Test send_message that returns a Message."""
mock_grpc_stub.SendMessage.return_value = a2a_pb2.SendMessageResponse(
msg=proto_utils.ToProto.message(sample_message)
)

response = await grpc_transport.send_message(sample_message_send_params)

mock_grpc_stub.SendMessage.assert_awaited_once()
assert isinstance(response, Message)
assert response.message_id == sample_message.message_id
assert get_text_parts(response.parts) == get_text_parts(
sample_message.parts
)


@pytest.mark.asyncio
async def test_get_task(
grpc_transport: GrpcTransport, mock_grpc_stub: AsyncMock, sample_task: Task
Expand Down
Loading