fix: Use HasField for simple message retrieval for grpc transport #380
Conversation
Using `response.task` will reset the oneof field if the `msg` field was set. Properly check and fix return value.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @timn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request implements a crucial fix in the gRPC transport layer to ensure proper handling of oneof fields in response messages. By utilizing the HasField method, the system now correctly checks for the presence of a specific oneof field without causing unintended side effects, thereby preventing data loss or corruption during message retrieval.
Highlights
- gRPC Message Handling Fix: Corrected the logic for retrieving messages from gRPC responses by switching from direct attribute access (
response.task) to usingresponse.HasField('task'). This change specifically addresses an issue where direct access to aoneoffield could inadvertently reset other fields within the response message if themsgfield was set.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
timn
force-pushed
the
timn/fix-grpc-sendmessage-result
branch
from
9d0b787 to
545acd3
Compare
🤖 I have created a release *beep* *boop* --- ## [0.3.1](v0.3.0...v0.3.1) (2025-08-13) ### Features * Add agent card as a route in rest adapter ([ba93053](ba93053)) ### Bug Fixes * gracefully handle task exceptions in event consumer ([#383](#383)) ([2508a9b](2508a9b)) * openapi working in sub-app ([#324](#324)) ([dec4b48](dec4b48)) * Pass `message_length` param in `get_task()` ([#384](#384)) ([b6796b9](b6796b9)) * relax protobuf dependency version requirement ([#381](#381)) ([0f55f55](0f55f55)) * Use HasField for simple message retrieval for grpc transport ([#380](#380)) ([3032aa6](3032aa6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
2 participants
Using
response.taskwill reset the oneof field if themsgfield was set. Properly check return value.