fix: relax protobuf dependency version requirement #381
Conversation
We want to use this in a project that requires `protobuf==6.31.1`. Version history indicates upgrading a2a-python to that version is not possible at the moment. Therefore, relax the required version to just be `>=5.29.5` (instead of `==`). This does print a warning when using a2a-python with a (major) newer version, but my tests show that it works just fine. Better to live with the warning than not being able to use a2a-python at all. This does not update the buf generation config as this would upgrade to newer proto requirements (and generate protos for newer versions).
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @timn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the project's interoperability by making its protobuf dependency more flexible. By loosening the version constraint, it allows consumers of this library to integrate it into environments where a newer major version of protobuf is already in use, thereby preventing potential dependency conflicts and enabling broader adoption without requiring an immediate upgrade of the library's internal protobuf generation.
Highlights
- Dependency Management: Relaxed the version requirement for the
protobuflibrary inpyproject.tomlfrom an exact match (==5.29.5) to a minimum version (>=5.29.5). This change aims to improve compatibility with other projects that may require a newerprotobufversion.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request relaxes the version constraint for the protobuf dependency, allowing for greater flexibility in projects that use this library. Adding an upper bound to the dependency is suggested to mitigate risks associated with future breaking changes.
🤖 I have created a release *beep* *boop* --- ## [0.3.1](v0.3.0...v0.3.1) (2025-08-13) ### Features * Add agent card as a route in rest adapter ([ba93053](ba93053)) ### Bug Fixes * gracefully handle task exceptions in event consumer ([#383](#383)) ([2508a9b](2508a9b)) * openapi working in sub-app ([#324](#324)) ([dec4b48](dec4b48)) * Pass `message_length` param in `get_task()` ([#384](#384)) ([b6796b9](b6796b9)) * relax protobuf dependency version requirement ([#381](#381)) ([0f55f55](0f55f55)) * Use HasField for simple message retrieval for grpc transport ([#380](#380)) ([3032aa6](3032aa6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
2 participants
We want to use this in a project that requires
protobuf==6.31.1. Version history indicates upgrading a2a-python to that version is not possible at the moment. Therefore, relax the required version to just be>=5.29.5(instead of==).This does print a warning when using a2a-python with a (major) newer version, but my tests show that it works just fine. Better to live with the warning than not being able to use a2a-python at all.
This does not update the buf generation config as this would upgrade to newer proto requirements (and generate protos for newer versions).