Skip to content

v3.2.0

Choose a tag to compare

View all tags
@aVadim483 aVadim483 released this 21 Jul 20:10
· 29 commits to main since this release
v3.2.0
1bad984

Bug fixes

Four defects in the sheet reading path, all in methods that had no test coverage.

  • Sheet::readFirstRowCellsFrom() always threw a TypeError. It forwarded $columnKeys into readFirstRowCells(?bool $styleIdxInclude), so even a default call failed. Because the result is keyed by cell address, column keys cannot apply at all — renaming a column would corrupt the address — so the parameter was dropped, mirroring readCellsFrom(). The new signature is readFirstRowCellsFrom(string $areaRange, ?bool $styleIdxInclude = null). No working call can break, since every call to the old signature threw.
  • Restricting columns while requesting numeric column keys returned only nulls. With a read area in place the row template was keyed by column letter while values were stored under numeric keys, and the values were then filtered out. Affected setReadArea() and setReadAreaColumns() combined with KEYS_COL_ZERO_BASED / KEYS_COL_ONE_BASED (and therefore KEYS_ZERO_BASED / KEYS_ONE_BASED). An explicit column name still takes precedence over the numeric key.
  • Sheet::rewind() discarded its $columnKeys argument, although it is documented as an alias of reset().
  • Sheet::firstCol() ignored the column bounds of the read area, reporting the first cell of the row as stored in the file. firstRow() was unaffected.

Tests

The suite grows from 84 to 262 tests (357 to 757 assertions), added ahead of the fixes as a regression net:

  • 105 characterization snapshots covering every read* method, the full KEYS_* matrix, result-mode flags, read areas, styles, dates, metadata and degenerate inputs, compared as whole arrays with assertSame.
  • Dedicated tests for generator semantics, read areas, result modes, merged cells, workbook delegation and streaming memory behaviour.
  • RESULT_MODE_ROW, TRIM_STRINGS, TREAT_EMPTY_STRING_AS_EMPTY_CELL and KEYS_RELATIVE had no coverage at all before and are now tested.

Method coverage: Sheet 33.9% → 58.9%, Excel 55.6% → 69.4%.

Notes

  • Reading XLSX files that use namespace-prefixed tags (<x:row>, <x:c>) still returns an empty result. This is a pre-existing limitation, now documented by a test rather than silently unnoticed.
  • API reference under docs/ regenerated.

Full changelog: v3.1.0...v3.2.0

Assets 2
Loading