Add trough/tropical-trough/instability-axis to training-viz callback - #46
Merged
aaTman merged 1 commit intoJul 27, 2026
Conversation
…lback callbacks.py had its own local 5-class FRONT_TYPE_CLASS_INDEX that was missed when the rest of the codebase (targets.py, evaluate.py, plot.py, configs) was expanded to 9 classes. Training-time visualization images and lite performance-diagram stats were silently excluding TROF/TT/INST. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/fronts/callbacks.pystill had a local, stale 5-classFRONT_TYPE_CLASS_INDEX(CF/WF/SF/OF/DL) that was missed when commit7bbd17eexpanded the rest of the codebase (targets.py,evaluate.py,plot/plot.py, allconfigs/schooner_*.yaml) to 9 classes.train.py'sTestVisualizationCallback, which drives the periodic W&B training-time prediction map and per-office-region lite performance diagrams — so troughs (TROF), tropical troughs (TT), and the instability axis (INST) were silently excluded from every training-time output image and stat, even though the main plotting/eval scripts fully supported them.plot.py/evaluate.pyexactly, and added a regression test locking parity in place.Test plan
pixi run -e linux pytest tests/test_callbacks.py -v— 18/18 pass, including newTestFrontTypeClassIndexparity testpixi run -e linux pytest tests/data/test_targets.py tests/test_train.py -v— 84 pass, 1 pre-existing unrelated failure (test_3d_config_parses, a data-variable-count assertion, reproduces identically onfeat/include-forming-dissipating-and-troughsbefore this change)plot_module.plot_test_predictionwith the updatedfront_typeslist — confirmed "Trough", "Tropical trough", and "Instability axis" now appear in the legend/output where before only CF/WF/SF/OF/DL did🤖 Generated with Claude Code