Skip to content

[Feat]: Refactor Diagnostics#12

Merged
aacebo merged 3 commits into
mainfrom
aacebo/feature-flag-diagnostics
Mar 11, 2026
Merged

[Feat]: Refactor Diagnostics#12
aacebo merged 3 commits into
mainfrom
aacebo/feature-flag-diagnostics

Conversation

@aacebo

@aacebo aacebo commented Mar 11, 2026

Copy link
Copy Markdown
Owner

#10

diagnostics are a nightly proc macro feature and so we use proc-macro2-diagnostics to bridge the gap the same way we do with proc-macro2 vs proc-macro. This dependency is for some people unneeded and unwanted, and so here I feature gate it and when the feature is not enabled, we use a workaround so we can still use the same code paths without the dependency, via printing the diagnostics to the console.

@aacebo aacebo linked an issue Mar 11, 2026 that may be closed by this pull request
@github-actions

github-actions Bot commented Mar 11, 2026

Copy link
Copy Markdown

🐰 Bencher Report

Branchaacebo/feature-flag-diagnostics
Testbedubuntu-latest

🚨 1 Alert

BenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Upper Boundary
(Limit %)
enum_extract_vanillaLatency
nanoseconds (ns)
📈 plot
🚷 threshold
🚨 alert (🔔)
284.10 ns
(+18.37%)Baseline: 240.01 ns
272.43 ns
(104.29%)

Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
attr_darling📈 view plot
🚷 view threshold
3,497.58 ns
(+0.47%)Baseline: 3,481.15 ns
3,711.23 ns
(94.24%)
attr_parse📈 view plot
🚷 view threshold
3,902.37 ns
(+1.84%)Baseline: 3,831.93 ns
4,109.58 ns
(94.96%)
attr_zyn📈 view plot
🚷 view threshold
3,032.06 ns
(-3.49%)Baseline: 3,141.72 ns
3,356.50 ns
(90.33%)
camel_heck📈 view plot
🚷 view threshold
381.76 ns
(+1.48%)Baseline: 376.21 ns
407.32 ns
(93.73%)
camel_zyn📈 view plot
🚷 view threshold
46.65 ns
(-33.92%)Baseline: 70.60 ns
172.89 ns
(26.98%)
codegen_vanilla📈 view plot
🚷 view threshold
7,730.47 ns
(+1.52%)Baseline: 7,614.67 ns
7,998.41 ns
(96.65%)
codegen_zyn📈 view plot
🚷 view threshold
5,870.69 ns
(-14.81%)Baseline: 6,891.41 ns
7,860.87 ns
(74.68%)
enum_codegen_vanilla📈 view plot
🚷 view threshold
9,271.74 ns
(+2.36%)Baseline: 9,057.94 ns
9,608.68 ns
(96.49%)
enum_codegen_zyn📈 view plot
🚷 view threshold
9,342.42 ns
(+1.68%)Baseline: 9,188.36 ns
9,669.56 ns
(96.62%)
enum_extract_vanilla📈 view plot
🚷 view threshold
🚨 view alert (🔔)
284.10 ns
(+18.37%)Baseline: 240.01 ns
272.43 ns
(104.29%)

enum_extract_zyn📈 view plot
🚷 view threshold
266.17 ns
(+0.08%)Baseline: 265.95 ns
302.47 ns
(88.00%)
enum_full_vanilla📈 view plot
🚷 view threshold
12,053.17 ns
(+3.81%)Baseline: 11,610.27 ns
12,385.25 ns
(97.32%)
enum_full_zyn📈 view plot
🚷 view threshold
12,303.15 ns
(+0.54%)Baseline: 12,236.48 ns
12,989.82 ns
(94.71%)
enum_parse_vanilla📈 view plot
🚷 view threshold
2,040.50 ns
(-3.59%)Baseline: 2,116.51 ns
2,341.10 ns
(87.16%)
enum_parse_zyn📈 view plot
🚷 view threshold
2,137.37 ns
(-4.04%)Baseline: 2,227.40 ns
2,472.30 ns
(86.45%)
extract_vanilla📈 view plot
🚷 view threshold
623.02 ns
(+2.39%)Baseline: 608.49 ns
653.70 ns
(95.31%)
extract_zyn📈 view plot
🚷 view threshold
635.50 ns
(+4.11%)Baseline: 610.40 ns
655.85 ns
(96.90%)
full_vanilla📈 view plot
🚷 view threshold
14,609.90 ns
(+1.63%)Baseline: 14,375.77 ns
15,352.00 ns
(95.17%)
full_zyn📈 view plot
🚷 view threshold
15,013.15 ns
(-0.22%)Baseline: 15,045.78 ns
16,733.35 ns
(89.72%)
kebab_heck📈 view plot
🚷 view threshold
382.91 ns
(+2.16%)Baseline: 374.81 ns
401.96 ns
(95.26%)
kebab_zyn📈 view plot
🚷 view threshold
45.05 ns
(+2.76%)Baseline: 43.84 ns
48.54 ns
(92.82%)
parse_vanilla📈 view plot
🚷 view threshold
6,020.47 ns
(-0.75%)Baseline: 6,065.77 ns
6,620.97 ns
(90.93%)
parse_zyn📈 view plot
🚷 view threshold
6,243.79 ns
(+1.13%)Baseline: 6,174.17 ns
6,718.94 ns
(92.93%)
pascal_heck📈 view plot
🚷 view threshold
379.91 ns
(+2.01%)Baseline: 372.42 ns
401.39 ns
(94.65%)
pascal_zyn📈 view plot
🚷 view threshold
43.63 ns
(-31.94%)Baseline: 64.10 ns
146.93 ns
(29.69%)
screaming_heck📈 view plot
🚷 view threshold
376.04 ns
(+1.85%)Baseline: 369.20 ns
397.34 ns
(94.64%)
screaming_zyn📈 view plot
🚷 view threshold
45.07 ns
(+1.43%)Baseline: 44.44 ns
48.71 ns
(92.53%)
snake_heck📈 view plot
🚷 view threshold
382.10 ns
(+2.43%)Baseline: 373.02 ns
399.78 ns
(95.58%)
snake_zyn📈 view plot
🚷 view threshold
45.05 ns
(-16.78%)Baseline: 54.14 ns
100.30 ns
(44.91%)
🐰 View full continuous benchmarking report in Bencher

@aacebo
aacebo merged commit 0c333dc into main Mar 11, 2026
2 of 3 checks passed
@aacebo
aacebo deleted the aacebo/feature-flag-diagnostics branch March 11, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] feature flag diagnostics

1 participant