asdf: implement Blosc2 compression - #219
Merged
Merged
Conversation
Complementing the existing decompression. The payload is a single cframe, matching what the Abacus C++ writer emits, and the codec defaults follow it too: zstd, clevel 1, shuffle, and blocks of a multiple of typesize near 1 MiB, which compresses better than the blosc2 default at the cost of some performance. Remaining kwargs go straight to blosc2.CParams. Note that ASDF hands compressors a flat uint8 buffer, so typesize defaults to 1 and shuffle does nothing unless the caller passes the record size via AsdfFile.set_array_compression(). Chunks and blocks are kept to a whole number of records: blosc has had a number of bugs around indivisible chunks. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complementing the existing decompression.
The payload is a single cframe, matching what the Abacus C++ writer emits, and the codec defaults follow it too: zstd, clevel 1, shuffle, and blocks of a multiple of typesize near 1 MiB, which compresses better than the blosc2 default at the cost of some performance. Remaining kwargs go straight to blosc2.CParams.
Note that ASDF hands compressors a flat uint8 buffer, so typesize defaults to 1 and shuffle does nothing unless the caller passes the record size via AsdfFile.set_array_compression().
Chunks and blocks are kept to a whole number of records: blosc has had a number of bugs around indivisible chunks.
Most of our AbacusAurora data products are going to get compressed through our C++ writer. But some post-processing might use this, and we would like all our data products to be on Blosc2.